Project

General

Profile

Actions

バグ #1562

closed

delegate_other = trueなPostboxをTimelineに追加するとクラッシュする

Added by Shibafu Midorino almost 3 years ago. Updated almost 3 years ago.

Status:
終了
Priority:
通常
Assignee:
-
Target version:
プラグイン名:
クラッシュする:
Yes

Description

delegate_other オプションを真にしたPostboxをTimelineに追加すると、NoMethodErrorでクラッシュします。
使っているプラグインはそんなに無い気がしますが…

例外情報

/Users/shibafu/git/mikutter-gtk3/plugin/gtk3/widget/timeline.rb:184:in `add_postbox': undefined method `postbox_delegation_generator' for #<Plugin::Gtk3::Timeline:0x7fb66d297270 ptr=0x7fb66a695cc0> (NoMethodError)
    from /Users/shibafu/git/mikutter-gtk3/plugin/gtk3/gtk3.rb:264:in `block (2 levels) in <top (required)>'
    from /Users/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/listener.rb:25:in `call'
    from /Users/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/event.rb:241:in `block (2 levels) in call_all_listeners'
    from /Users/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/event.rb:240:in `each'
    from /Users/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/event.rb:240:in `block in call_all_listeners'
    from /Users/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/event.rb:239:in `catch'
    from /Users/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/event.rb:239:in `call_all_listeners'
    from /Users/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/event.rb:62:in `block in call'
    from /Users/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/delayer-1.2.1/lib/delayer/procedure.rb:26:in `run'
    from /Users/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/delayer-1.2.1/lib/delayer/extend.rb:126:in `run_once_without_pop_reserve'
    from /Users/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/delayer-1.2.1/lib/delayer/extend.rb:117:in `run_once'
    from /Users/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/delayer-1.2.1/lib/delayer.rb:38:in `method_missing'
    from /Users/shibafu/git/mikutter-gtk3/plugin/gtk3/mainloop.rb:23:in `block (2 levels) in mainloop'
    from /Users/shibafu/git/mikutter-gtk3/plugin/gtk3/mainloop.rb:12:in `loop'
    from /Users/shibafu/git/mikutter-gtk3/plugin/gtk3/mainloop.rb:12:in `block in mainloop'
    from /Users/shibafu/git/mikutter-gtk3/plugin/gtk3/mainloop.rb:10:in `catch'
    from /Users/shibafu/git/mikutter-gtk3/plugin/gtk3/mainloop.rb:10:in `mainloop'
    from mikutter.rb:79:in `boot!'
    from mikutter.rb:115:in `<main>'

実行環境

  • mikutter 5.0.0
  • macOS 11.6.2, Quartz-backend GTK 3.24.30
  • direct_message 552f47e52f3a7d9f0b9ffcbfc93dd0c872066d49

再現手順

direct_messageプラグインを入れた状態で、Twitterユーザのプロフィールタブを開く

Actions #1

Updated by Shibafu Midorino almost 3 years ago

当該プラグインの、対象オプションを付けたPostbox生成要求はこの辺と思われます。

https://github.com/mikutter/direct_message/blob/552f47e52f3a7d9f0b9ffcbfc93dd0c872066d49/direct_message.rb#L83-L85

Actions #2

Updated by Shibafu Midorino almost 3 years ago

  • Status changed from 分類待ち to 実装待ち
Actions #3

Updated by Shibafu Midorino almost 3 years ago

  • Status changed from 実装待ち to レビュー待ち
  • ブランチ set to topic/1562-default-postbox-delegation-generator

とりあえずパッチは先走って書いたので、もしwontfixなら閉じちゃってください。

Actions #4

Updated by toshi_a 初音 almost 3 years ago

  • Status changed from レビュー待ち to マージ待ち
Actions #5

Updated by toshi_a 初音 almost 3 years ago

  • Status changed from マージ待ち to 終了

merged.

Actions #6

Updated by Izumi Tsutsui almost 3 years ago

develop のみにマージされてますが 5.0 が master branch ならば master にマージ必要という気もします。
どうなんでしょう。

Actions

Also available in: Atom PDF