Project

General

Profile

Actions

バグ #1534

closed

gtk3: トゥートを削除すると完了後にクラッシュする

Added by Shibafu Midorino 7 months ago. Updated 7 months ago.

Status:
終了
Priority:
通常
Assignee:
-
Target version:
プラグイン名:
ブランチ:
topic/1534-fix-lost-trust-and-process
クラッシュする:
Yes

Description

gtk3環境でトゥートを削除すると、削除完了後にmikutterがクラッシュします。
複数選択している場合、最初の1つ目の削除ダイアログが閉じた後にクラッシュするため、2つ目以降については何もできませんでした。

バックトレース

/home/shibafu/git/mikutter-gtk3/plugin/gtk3/widget/timeline.rb:119:in `block in bulk_remove': undefined method `uri' for [mastodon-status(https://social.mikutter.hachune.net/@shibafu528/107212406523281474 test)]:Array (NoMethodError)
        from /home/shibafu/git/mikutter-gtk3/plugin/gtk3/widget/timeline.rb:118:in `map'
        from /home/shibafu/git/mikutter-gtk3/plugin/gtk3/widget/timeline.rb:118:in `bulk_remove'
        from /home/shibafu/git/mikutter-gtk3/plugin/gtk3/widget/timeline.rb:19:in `block in remove_rows'
        from /home/shibafu/git/mikutter-gtk3/plugin/gtk3/widget/timeline.rb:18:in `each'
        from /home/shibafu/git/mikutter-gtk3/plugin/gtk3/widget/timeline.rb:18:in `remove_rows'
        from /home/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/listener.rb:25:in `call'
        from /home/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/event.rb:241:in `block (2 levels) in call_all_listeners'
        from /home/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/event.rb:240:in `each'
        from /home/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/event.rb:240:in `block in call_all_listeners'
        from /home/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/event.rb:239:in `catch'
        from /home/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/event.rb:239:in `call_all_listeners'
        from /home/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/event.rb:62:in `block in call'
        from /home/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/delayer-1.2.1/lib/delayer/procedure.rb:26:in `run'
        from /home/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/delayer-1.2.1/lib/delayer/extend.rb:126:in `run_once_without_pop_reserve'
        from /home/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/delayer-1.2.1/lib/delayer/extend.rb:117:in `run_once'
        from /home/shibafu/git/mikutter-gtk3/vendor/bundle/ruby/3.0.0/gems/delayer-1.2.1/lib/delayer.rb:38:in `method_missing'
        from /home/shibafu/git/mikutter-gtk3/plugin/gtk3/mainloop.rb:23:in `block (2 levels) in mainloop'
        from /home/shibafu/git/mikutter-gtk3/plugin/gtk3/mainloop.rb:12:in `loop'
        from /home/shibafu/git/mikutter-gtk3/plugin/gtk3/mainloop.rb:12:in `block in mainloop'
        from /home/shibafu/git/mikutter-gtk3/plugin/gtk3/mainloop.rb:10:in `catch'
        from /home/shibafu/git/mikutter-gtk3/plugin/gtk3/mainloop.rb:10:in `mainloop'
        from mikutter.rb:79:in `boot!'
        from mikutter.rb:115:in `<main>'

再現手順

  1. 信頼を失うようなトゥートをする
  2. そのトゥートを削除する
Actions #1

Updated by Shibafu Midorino 7 months ago

  • Status changed from 分類待ち to 実装待ち
  • Assignee set to Shibafu Midorino
Actions #2

Updated by Shibafu Midorino 7 months ago

  • Status changed from 実装待ち to レビュー待ち
  • Assignee deleted (Shibafu Midorino)
  • ブランチ set to topic/1534-fix-lost-trust-and-process
Actions #3

Updated by Izumi Tsutsui 7 months ago

  • Status changed from レビュー待ち to マージ待ち

git merge topic/1534-fix-lost-trust-and-process で削除テストしてOKっぽいです

Actions #4

Updated by Shibafu Midorino 7 months ago

  • Status changed from マージ待ち to 終了

merged

Actions

Also available in: Atom PDF