Project

General

Profile

Actions

バグ #1491

closed

ggrksがRuby3.0.0で削除されたURI.escapeを使用している

Added by Akira Ouchi 20 days ago. Updated 15 days ago.

Status:
終了
Priority:
通常
Assignee:
Target version:
プラグイン名:
ブランチ:
topic/1491-ggrks
クラッシュする:
Yes

Description

タイトルのとおりで、ググるとクラッシュしていました。

URI.encode_www_formに置き換えたパッチを添付します。

/Users/akkie/mikutter/plugin/command/command.rb:172:in `block (2 levels) in <top (required)>': undefined method `escape' for URI:Module (NoMethodError)
    from /Users/akkie/mikutter/plugin/shortcutkey/shortcutkey.rb:30:in `block (3 levels) in <top (required)>'
    from /Users/akkie/mikutter/plugin/shortcutkey/shortcutkey.rb:28:in `<<'
    from /Users/akkie/mikutter/plugin/shortcutkey/shortcutkey.rb:28:in `each'
    from /Users/akkie/mikutter/plugin/shortcutkey/shortcutkey.rb:28:in `each'
    from /Users/akkie/mikutter/plugin/shortcutkey/shortcutkey.rb:28:in `each'
    from /Users/akkie/mikutter/plugin/shortcutkey/shortcutkey.rb:28:in `each'
    from /Users/akkie/mikutter/plugin/shortcutkey/shortcutkey.rb:28:in `block (2 levels) in <top (required)>'
    from /Users/akkie/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/filter.rb:34:in `filtering'
    from /Users/akkie/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/event.rb:82:in `block (2 levels) in filtering'
    from /Users/akkie/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/event.rb:81:in `each'
    from /Users/akkie/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/event.rb:81:in `reduce'
    from /Users/akkie/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/event.rb:81:in `block in filtering'
    from /Users/akkie/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/event.rb:80:in `catch'
    from /Users/akkie/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/event.rb:80:in `filtering'
    from /Users/akkie/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/pluggaloid-1.7.0/lib/pluggaloid/plugin.rb:66:in `filtering'
    from /Users/akkie/mikutter/plugin/gui/dsl.rb:30:in `keypress'
    from /Users/akkie/mikutter/plugin/gtk/gtk.rb:232:in `block in timeline_key_press_event'
    from /Users/akkie/mikutter/core/mui/gtk_extension.rb:35:in `block in safety_signal_connect'
    from /Users/akkie/mikutter/plugin/gtk/mainloop.rb:18:in `main_iteration'
    from /Users/akkie/mikutter/plugin/gtk/mainloop.rb:18:in `block (2 levels) in mainloop'
    from /Users/akkie/mikutter/plugin/gtk/mainloop.rb:12:in `loop'
    from /Users/akkie/mikutter/plugin/gtk/mainloop.rb:12:in `block in mainloop'
    from /Users/akkie/mikutter/plugin/gtk/mainloop.rb:10:in `catch'
    from /Users/akkie/mikutter/plugin/gtk/mainloop.rb:10:in `mainloop'
    from mikutter.rb:81:in `boot!'
    from mikutter.rb:117:in `<main>'

Files

ggrks.diff (686 Bytes) ggrks.diff Akira Ouchi, 2021-09-06 23:18

再現手順

  • タイムラインから文字列を選択する
  • 右クリックしてggrksを選択する
Actions #1

Updated by toshi_a 初音 15 days ago

  • Status changed from パッチ適用待ち to レビュー待ち
  • Assignee changed from toshi_a 初音 to Akira Ouchi
  • Target version set to 4.1
  • ブランチ set to topic/1491-ggrks
  • クラッシュする changed from No to Yes

再現できました。そのまま取り込みますが一応確認お願いします

Actions #2

Updated by Akira Ouchi 15 days ago

確認ありがとうございました。
パッチ適用後の動作確認もできましたー。

Actions #3

Updated by toshi_a 初音 15 days ago

  • Status changed from レビュー待ち to 終了

merged.

Actions

Also available in: Atom PDF