Actions
バグ #1288
closedemojiを含むURLを表示すると(?)クラッシュする
プラグイン名:
クラッシュする:
Yes
Description
恐らくこのトゥート https://social.mikutter.hachune.net/@metalefty/100558835573340511 を表示すると落ちます。
IDN::Idna::IdnaError 文字列準備中で失敗 (1) {MIKUTTER_DIR}/vendor/bundle/ruby/2.5.0/gems/addressable-2.5.1/lib/addressable/idna/native.rb:38:in `toASCII' {MIKUTTER_DIR}/vendor/bundle/ruby/2.5.0/gems/addressable-2.5.1/lib/addressable/idna/native.rb:38:in `block in to_ascii' {MIKUTTER_DIR}/vendor/bundle/ruby/2.5.0/gems/addressable-2.5.1/lib/addressable/idna/native.rb:36:in `map' {MIKUTTER_DIR}/vendor/bundle/ruby/2.5.0/gems/addressable-2.5.1/lib/addressable/idna/native.rb:36:in `to_ascii' {MIKUTTER_DIR}/vendor/bundle/ruby/2.5.0/gems/addressable-2.5.1/lib/addressable/uri.rb:1092:in `normalized_host' {MIKUTTER_DIR}/vendor/bundle/ruby/2.5.0/gems/addressable-2.5.1/lib/addressable/uri.rb:823:in `freeze' {MIKUTTER_DIR}/vendor/bundle/ruby/2.5.0/gems/diva-0.3.2/lib/diva/uri.rb:75:in `to_uri' {MIKUTTER_DIR}/vendor/bundle/ruby/2.5.0/gems/diva-0.3.2/lib/diva/uri.rb:104:in `method_missing' {MIKUTTER_DIR}/core/plugin/search/model/search.rb:13:in `block in <class:Search>' {MIKUTTER_DIR}/core/lib/diva_hacks/model.rb:100:in `block (2 levels) in handle' {MIKUTTER_DIR}/vendor/bundle/ruby/2.5.0/gems/pluggaloid-1.1.1/lib/pluggaloid/filter.rb:28:in `filtering' {MIKUTTER_DIR}/vendor/bundle/ruby/2.5.0/gems/pluggaloid-1.1.1/lib/pluggaloid/event.rb:59:in `block (2 levels) in filtering' {MIKUTTER_DIR}/vendor/bundle/ruby/2.5.0/gems/pluggaloid-1.1.1/lib/pluggaloid/event.rb:58:in `each' {MIKUTTER_DIR}/vendor/bundle/ruby/2.5.0/gems/pluggaloid-1.1.1/lib/pluggaloid/event.rb:58:in `reduce' {MIKUTTER_DIR}/vendor/bundle/ruby/2.5.0/gems/pluggaloid-1.1.1/lib/pluggaloid/event.rb:58:in `block in filtering' {MIKUTTER_DIR}/vendor/bundle/ruby/2.5.0/gems/pluggaloid-1.1.1/lib/pluggaloid/event.rb:57:in `catch' {MIKUTTER_DIR}/vendor/bundle/ruby/2.5.0/gems/pluggaloid-1.1.1/lib/pluggaloid/event.rb:57:in `filtering' {MIKUTTER_DIR}/vendor/bundle/ruby/2.5.0/gems/pluggaloid-1.1.1/lib/pluggaloid/plugin.rb:63:in `filtering' {MIKUTTER_DIR}/core/mui/cairo_sub_parts_quote.rb:35:in `block (2 levels) in initialize' {MIKUTTER_DIR}/core/mui/cairo_sub_parts_quote.rb:38:in `each' {MIKUTTER_DIR}/core/mui/cairo_sub_parts_quote.rb:38:in `each' {MIKUTTER_DIR}/core/mui/cairo_sub_parts_quote.rb:38:in `each' {MIKUTTER_DIR}/core/mui/cairo_sub_parts_quote.rb:38:in `each' {MIKUTTER_DIR}/core/mui/cairo_sub_parts_quote.rb:38:in `each' {MIKUTTER_DIR}/core/mui/cairo_sub_parts_quote.rb:38:in `find' {MIKUTTER_DIR}/core/mui/cairo_sub_parts_quote.rb:38:in `block in initialize' {MIKUTTER_DIR}/core/mui/cairo_sub_parts_quote.rb:33:in `map' {MIKUTTER_DIR}/core/mui/cairo_sub_parts_quote.rb:33:in `initialize' {MIKUTTER_DIR}/core/mui/cairo_sub_parts_helper.rb:21:in `new' {MIKUTTER_DIR}/core/mui/cairo_sub_parts_helper.rb:21:in `block in subparts' {MIKUTTER_DIR}/core/mui/cairo_sub_parts_helper.rb:21:in `map' {MIKUTTER_DIR}/core/mui/cairo_sub_parts_helper.rb:21:in `subparts' {MIKUTTER_DIR}/core/lib/uithreadonly.rb:22:in `block (2 levels) in singleton class' {MIKUTTER_DIR}/core/mui/cairo_sub_parts_helper.rb:41:in `_subparts_height' {MIKUTTER_DIR}/core/mui/cairo_sub_parts_helper.rb:34:in `subparts_height' {MIKUTTER_DIR}/core/lib/uithreadonly.rb:22:in `block (2 levels) in singleton class' {MIKUTTER_DIR}/core/mui/cairo_coordinate_module.rb:48:in `height' {MIKUTTER_DIR}/core/lib/uithreadonly.rb:22:in `block (2 levels) in singleton class' {MIKUTTER_DIR}/core/mui/cairo_cell_renderer_message.rb:145:in `render_message' {MIKUTTER_DIR}/core/mui/cairo_cell_renderer_message.rb:128:in `uri=' {MIKUTTER_DIR}/core/plugin/gtk/mainloop.rb:10:in `main' {MIKUTTER_DIR}/core/plugin/gtk/mainloop.rb:10:in `mainloop' ./mikutter.rb:69:in `boot!' ./mikutter.rb:105:in `<main>'
Updated by cob odo about 6 years ago
本文をここに引用しようかと思いましたが、RedmineがInternal Server Errorを返すので諦めました。
Updated by cob odo about 6 years ago
環境はWSL上のUbuntu 18.04です。
vendor/bundle/ruby/2.5.0/gems/diva-0.3.2/lib/diva/uri.rb の
@uri ||= generate_uri.freeze
を
@uri ||= generate_uri
に変えると落ちなくなります。
Updated by toshi_a 初音 about 6 years ago
- Tracker changed from 機能 to バグ
- Status changed from 新規 to パッチ適用待ち
- Start date deleted (
2018-08-16) - クラッシュする set to No
Adressable 2.5.2で修正または対応された問題のようです。
https://github.com/sporkmonger/addressable/blob/master/CHANGELOG.md#addressable-252
Adressable 2.5.2以降を利用するように強制してみました。
Updated by toshi_a 初音 about 6 years ago
- Status changed from パッチ適用待ち to レビュー待ち
- Assignee set to cob odo
- ブランチ set to topic/1288-addressable-252
commitしました。レビュー終わったらそのままmasterにmergeして終了して良いです。
Updated by cob odo about 6 years ago
- Status changed from レビュー待ち to マージ待ち
確認しました。
しましたが、ちょっと手元環境でpushできない状況なので、マージしてもらえますでしょうか。
お手数ですがよろしくお願いします。
Actions