Project

General

Profile

バグ #1223

自分のプロフィールタブを開いたときにGtk-CRITICAL **: gtk_box_pack: assertion 'GTK_IS_WIDGET (child)' failedが出る

Added by Akira Ouchi about 1 year ago. Updated about 1 year ago.

Status:
終了
Priority:
通常
Assignee:
Target version:
プラグイン名:
user_detail_view
ブランチ:
topic/1223-stderr-output-when-open-my-twitter-profile
クラッシュする:
No

Description

自分のプロフィールタブを開くと、以下の出力が出ます。他人の場合は出ません。

Gtk-CRITICAL **: gtk_box_pack: assertion 'GTK_IS_WIDGET (child)' failed
    from /Users/akkie/mikutter/core/mui/gtk_extension.rb:227:in `closeup'
    from /Users/akkie/mikutter/core/plugin/user_detail_view/user_detail_view.rb:258:in `block in relation_bar'
    from /Users/akkie/mikutter/core/plugin/user_detail_view/user_detail_view.rb:189:in `each'
    from /Users/akkie/mikutter/core/plugin/user_detail_view/user_detail_view.rb:189:in `relation_bar'
    from /Users/akkie/mikutter/core/plugin/user_detail_view/user_detail_view.rb:90:in `block (2 levels) in <top (required)>'
    from /Users/akkie/mikutter/core/plugin/gui/widget.rb:70:in `instance_eval'
    from /Users/akkie/mikutter/core/plugin/gui/widget.rb:70:in `instance_eval_with_delegate'
    from /Users/akkie/mikutter/core/plugin/gui/gui.rb:74:in `block (5 levels) in <top (required)>'
    from /Users/akkie/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/pluggaloid-1.1.1/lib/pluggaloid/plugin.rb:148:in `handler_tag'
    from /Users/akkie/mikutter/core/plugin/gui/gui.rb:71:in `block (4 levels) in <top (required)>'
    from /Users/akkie/mikutter/core/plugin/user_detail_view/user_detail_view.rb:61:in `each'
    from /Users/akkie/mikutter/core/plugin/user_detail_view/user_detail_view.rb:61:in `block in show_profile'
    from /Users/akkie/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/delayer-deferred-2.0.0/lib/delayer/deferred/chain/base.rb:18:in `activate'
    from /Users/akkie/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/delayer-deferred-2.0.0/lib/delayer/deferred/worker.rb:93:in `block (2 levels) in wait_and_activate'
    from /Users/akkie/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/delayer-deferred-2.0.0/lib/delayer/deferred/worker.rb:87:in `catch'
    from /Users/akkie/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/delayer-deferred-2.0.0/lib/delayer/deferred/worker.rb:87:in `block in wait_and_activate'
    from /Users/akkie/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/delayer-deferred-2.0.0/lib/delayer/deferred/worker.rb:86:in `catch'
    from /Users/akkie/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/delayer-deferred-2.0.0/lib/delayer/deferred/worker.rb:86:in `wait_and_activate'
    from /Users/akkie/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/delayer-deferred-2.0.0/lib/delayer/deferred/worker.rb:76:in `block (2 levels) in fiber'
    from /Users/akkie/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/delayer-deferred-2.0.0/lib/delayer/deferred/worker.rb:75:in `loop'
    from /Users/akkie/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/delayer-deferred-2.0.0/lib/delayer/deferred/worker.rb:75:in `block in fiber'

https://dev.mikutter.hachune.net/projects/mikutter/repository/revisions/master/entry/core/plugin/user_detail_view/user_detail_view.rb#L258 で、
followbuttonをcloseupするとき、followbuttonは他人のプロフィールタブを開いたときにしか作成されていないためエラーになっていました。

followbuttonが作られたときだけcloseupするようにパッチを作成してみたので添付します。


Files

my_profile_tab.diff (924 Bytes) my_profile_tab.diff Akira Ouchi, 2018-05-04 02:12

再現手順

debugで起動する
自分のプロフィールタブを開いて出力を確認する
他人のプロフィールタブを開いて出力がないことを確認する

Associated revisions

Revision 3fdb4af2 (diff)
Added by Akira Ouchi about 1 year ago

user_detail_view: 自分のプロフィールタブを開いたときに警告が出力される refs #1223

History

#1

Updated by toshi_a 初音 about 1 year ago

  • Status changed from 分類待ち to パッチ適用待ち

たしかにこれはおかしいですね。パッチの内容が正しそうです。

#2

Updated by toshi_a 初音 about 1 year ago

  • Status changed from パッチ適用待ち to レビュー待ち
  • Assignee set to Akira Ouchi
  • ブランチ set to topic/1223-stderr-output-when-open-my-twitter-profile

多分動くと思うからcommitしました!3.6を起点に始めると他の箇所も変わってたので一応確認お願いします。

#3

Updated by Akira Ouchi about 1 year ago

  • Status changed from レビュー待ち to マージ待ち

多分動いてるので大丈夫そうです。

#4

Updated by toshi_a 初音 about 1 year ago

  • Status changed from マージ待ち to 終了

Also available in: Atom PDF